♻️ Frontend: Notifications cleanup #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2023 10:10
GitHK
added
a:webserver
added 6 commits
March 21, 2023 10:56
Codecov Report
@@ Coverage Diff @@
## master #4004 +/- ##
=========================================
- Coverage 85.9% 78.1% -7.8%
=========================================
Files 899 394 -505
Lines 38757 20345 -18412
Branches 849 137 -712
=========================================
- Hits 33302 15906 -17396
+ Misses 5233 4390 -843
+ Partials 222 49 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pcrespov
approved these changes
Mar 21, 2023
services/web/server/src/simcore_service_webserver/redis_user_notifications.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Mar 21, 2023
added 3 commits
March 22, 2023 10:33
odeimaiz
reviewed
Mar 22, 2023
services/web/server/src/simcore_service_webserver/user_notifications.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/user_notifications.py
Outdated
Show resolved
Hide resolved
odeimaiz
reviewed
Mar 22, 2023
services/web/server/src/simcore_service_webserver/users_handlers.py
Outdated
Show resolved
Hide resolved
odeimaiz
approved these changes
Mar 22, 2023
sanderegg
approved these changes
Mar 22, 2023
added 2 commits
March 23, 2023 07:58
…tifications-followup
|
Code Climate has analyzed commit 49c7cff and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a followup of #3937
Related issue/s
How to test
Checklist