Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need this after bluesky/ophyd-async#594 gets merged and released upstream - draft PR at the moment.
Current issues:
Fails pyright
My assumption is that's an upstream bug that will be fixed before they release the new typing.
trigger
with no timeout seems broken? (fixed)await dae.controls.end_run.trigger(wait=True, timeout=None)
causes the following error, despite the fact that it should be waiting with no timeout: