Start model refactoring and fix tests #101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started refactoring in
models.py
(more changes will follow). This is WIP, but as a first step to overall refactoring we think this could already be reviewed.During the refactoring we found that in one place the calculation differed from those in other places.
In the original code for
tasrange
a factor 2 was missing when calculating the weights.https://github.com/ISI-MIP/attrici/blob/8a735037f3d0e78f842e9646bcb66614179bc2df/attrici/models.py#L554C1-L554C90
The resulting changes in the output are minor, we adjusted the accuracy of the tests accordingly.
This PR also includes a fix for the tests to always run the tests (which are only run locally, not in CI, because they take some time to run) without using the cache.