Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parsing of west.yml when determening NCS version #114

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

TjazVracko
Copy link
Contributor

Description

Turns our a "project" within west.yml does not need to contain the repo-path key.
I fix this by using .get instead of [].

Areas of interest for the reviewer

All

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed
    functions.
  • I updated all customer-facing technical documentation. - This PR introduced only internal facing changes.

After-review steps

  • Reviewer can merge and delete the branch.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @TjazVracko and the rest of your teammates on Graphite Graphite

@TjazVracko TjazVracko force-pushed the fix/west-manifest-without-repo-path branch 3 times, most recently from 879b372 to 34e6681 Compare October 2, 2024 12:21
Copy link
Collaborator

@MarkoSagadin MarkoSagadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this!

I see that I actually implemented this function wrongly initially, the .get() accessor is the correct way to do it, not with with the try, except blocks.

But this means that with .get() the try, except blocks are redundant. Can you remove them?

Additionally, in the same light, is the "revision" field also optional?
If yes, could you also add a check for that?

Copy link
Contributor Author

Thank you for finding this!

I see that I actually implemented this function wrongly initially, the .get() accessor is the correct way to do it, not with with the try, except blocks.

But this means that with .get() the try, except blocks are redundant. Can you remove them?

Additionally, in the same light, is the "revision" field also optional?
If yes, could you also add a check for that?

This section of the docs describes what is mandatory and what is optional: https://docs.zephyrproject.org/latest/develop/west/manifest.html#id7
The revision is optional...
I will add this logic as well.

@TjazVracko TjazVracko force-pushed the fix/west-manifest-without-repo-path branch from 34e6681 to 0c4ec15 Compare October 3, 2024 06:05
Copy link
Collaborator

@MarkoSagadin MarkoSagadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/east/helper_functions.py Outdated Show resolved Hide resolved
@MarkoSagadin MarkoSagadin merged commit 8a69c37 into main Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants