-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parsing of west.yml when determening NCS version #114
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @TjazVracko and the rest of your teammates on Graphite |
879b372
to
34e6681
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finding this!
I see that I actually implemented this function wrongly initially, the .get()
accessor is the correct way to do it, not with with the try
, except
blocks.
But this means that with .get()
the try
, except
blocks are redundant. Can you remove them?
Additionally, in the same light, is the "revision"
field also optional?
If yes, could you also add a check for that?
This section of the docs describes what is mandatory and what is optional: https://docs.zephyrproject.org/latest/develop/west/manifest.html#id7 |
34e6681
to
0c4ec15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Turns our a "project" within west.yml does not need to contain the
repo-path
key.I fix this by using .get instead of [].
Areas of interest for the reviewer
All
Checklist
functions.
I updated all customer-facing technical documentation.- This PR introduced only internal facing changes.After-review steps