Fix permissions issue on macOS when seeding. #1106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting Git's configuration option
safe.directory
to/work
is enough to allow working on a pre-seeded repository (when the repository root is bound to/work
in the container), but does not work when seeding a new repository, because then the root of the newly created repository is not the/work
directory itself, but is in fact located two directories below that (under/work/target/<name>
). Thesafe.directory
directive has thus no effect when seeding.We must set
safe.directory
to*
instead, to completely disable the permission check regardless of where the repository is. Security-wise, this does not change anything -- that check does not bring any security benefit in the context of the ODK, and we were already disabling it when working on pre-seeded repositories.closes #1105