Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.sh: Check for spaces in the path to the current directory. #1079

Merged
merged 2 commits into from
Jul 4, 2024

Commits on Jun 29, 2024

  1. run.sh: Check for spaces in the path to the current directory.

    The shell wrapper script for the ODK is assuming that the directory
    containing the repository does not contain spaces in its path. This is
    required for the logic that binds the repository to the /work directory
    inside the container to work, and we may not change that without
    breaking the requirement that the wrapper script shall be POSIX
    compliant (supporting space-containing paths would require using
    array-typed variables, which are not specified by POSIX).
    
    This commit adds an explicit check at the beginning of the wrapper
    script to ensure that the current working directory does not contain any
    spaces, and immediately abort if it does.
    
    closes #1078
    gouttegd committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    ed54e84 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Configuration menu
    Copy the full SHA
    30f81d7 View commit details
    Browse the repository at this point in the history