Skip to content

Commit

Permalink
Ensure run.sh properly reports failure.
Browse files Browse the repository at this point in the history
Add a 'set -e' instruction at the very beginning of the `run.sh` wrapper
script. This is to ensure the script immediately exits with a proper
error code upon the first failure.

Without such a precaution, running any workflow whose name matches the
'*update_repo*' or '*release*' patterns leads the script to
unconditionally returns a success error code, because the last command
the script executes is the final 'echo' command and _not_ the 'docker
run' command.

closes #981
  • Loading branch information
gouttegd committed Jan 19, 2024
1 parent ec77d2f commit 087a327
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions template/src/ontology/run.sh.jinja2
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
#
# See README-editors.md for more details.

set -e

if [ -f run.sh.conf ]; then
. ./run.sh.conf
fi
Expand Down

0 comments on commit 087a327

Please sign in to comment.