Skip to content

Commit

Permalink
update descriptions of ClassCreation and ObjectPropertyCreation
Browse files Browse the repository at this point in the history
Updating ClassCreation description as per @cmungall's suggestion. I guessed at how to update the description for ObjectPropertyCreation; not sure I got it right.

Fixed a few minor typos I noticed.

BTW, I do not understand these comments (which appeared twice starting at line 928):

 - if a node obsoletion C, C about N1, and C has direct replacement N2, and there
      exists an edge with an edge property referencing N1, it is possible to replace
      with N2
    - if a node obsoletion C C about N1, and C has direct replacement N2, then N1 IAO:0100001
      N2

(Mostly I don't understand "C about N1". Should "about" be some other word?)
  • Loading branch information
nlharris authored Sep 5, 2024
1 parent 8a62f0e commit d69fda7
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/kgcl_schema/schema/kgcl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -675,23 +675,23 @@ classes:
- http://wiki.geneontology.org/index.php/Guidelines_for_creating_a_GO_term
ClassCreation:
is_a: NodeCreation
description: A node creation where the owl type is 'owl:Class'
description: A node creation where the node is a class (as opposed to a relation)
slots:
- superclass
slot_usage:
change_description:
string_serialization: create class {about_node}
ObjectPropertyCreation:
is_a: NodeCreation
description: A node creation where the owl type is 'ObjectProperty'
description: A node creation where the node is a property
slot_usage:
change_description:
string_serialization: create object property {about_node}
NodeDeletion:
is_a: NodeChange
mixins:
- Deletion
description: Deletion of a node from the graph. Note it is recommended nodes are
description: Deletion of a node from the graph. Note: it is recommended nodes are
obsoleted and never merged, but this operation exists to represent deletions
in ontologies, accidental or otherwise
slot_usage:
Expand Down Expand Up @@ -881,7 +881,7 @@ slots:
deprecated: no longer required
description: 'The type of a property (URI, CURIE, label) '
change_description:
description: A string serialization of the change. This should be both human-readable,
description: A string serialization of the change. This should be both human-readable
and parseable.
comments:
- Form 1: IRIs are denoted by CURIEs, optionally followed by label in parenthesis
Expand All @@ -896,7 +896,7 @@ slots:
under 'biological process' retaining as 'exact synonym'
has_textual_diff:
description: A representation of character-level changes on a textual literal
property. For example, if a text definition may change by only a single character
property. For example, if a text definition changes by only a single character
such as addition of a period, it is useful to be able to see this visually.
comments:
- this is NOT for representing the diff of the change as a whole.
Expand Down Expand Up @@ -928,7 +928,7 @@ slots:
- if a node obsoletion C, C about N1, and C has direct replacement N2, and there
exists an edge with an edge property referencing N1, it is possible to replace
with N2
- if a node obsoletion C C about N1, and Chas direct replacement N2, then N1 IAO:0100001
- if a node obsoletion C C about N1, and C has direct replacement N2, then N1 IAO:0100001
N2
has_nondirect_replacement:
range: Node
Expand Down

0 comments on commit d69fda7

Please sign in to comment.