Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint for all files #755

Open
wants to merge 103 commits into
base: master
Choose a base branch
from
Open

Fix eslint for all files #755

wants to merge 103 commits into from

Conversation

modos189
Copy link
Contributor

@modos189 modos189 commented Aug 28, 2024 •
edited
Loading

Fixed the style, in some cases minor refactoring or bug fixes have been made, in such cases I tried to mention it in the commit message

  • Fix eslint for core files
  • Fix eslint for plugins

@modos189 modos189 added the development general development issue label Aug 28, 2024
@xscreach
Copy link
Contributor

Frankly, i was saying we should do this long time ago, but the concensus from TG was that it will mess with history making it harder to find the real "owner" of the changes thus "we" don't want this to happen...

Did this change? I'm personally all for this, but we agreed differently... so... 🤷‍♂️

Are "we" really ok with it? 🤷‍♂️

@modos189
Copy link
Contributor Author

Really, I didn't want to do it before. But it turned out that so much time has passed, and we still have a lot of code that does not conform to the style, which makes it difficult to understand and complicates the preparation of new changes.
So I think we need to bring the files to the style. I want to know what other people think

@xscreach
Copy link
Contributor

Really, I didn't want to do it before. But it turned out that so much time has passed, and we still have a lot of code that does not conform to the style, which makes it difficult to understand and complicates the preparation of new changes.
So I think we need to bring the files to the style. I want to know what other people think

Cool, cool 👍
I'm all for/pro this thing. As you said, it will make new changes easier in terms of preparing "green" PR, lot fewer people pissed from the constant eslint complains and code better readable (at least not all red in IDE cause of broken codestyle 🤪), etc...

I'll just note that we should test this PR before merging as it's changing every single file (or like 99% of them). It should be all good... it's just eslint fix... but... it could also be, for some stupid reason, very bad 😬

@modos189
Copy link
Contributor Author

I'll just note that we should test this PR before merging as it's changing every single file (or like 99% of them). It should be all good... it's just eslint fix... but... it could also be, for some stupid reason, very bad 😬

Yes, it's true. For example, I had to add some eslint-disable-next-line in boot.js. After the fixes, the build completed successfully and I didn't notice any errors, but I might have missed something

@modos189 modos189 force-pushed the fix/eslint-all-files branch 3 times, most recently from d86f409 to ca0eed9 Compare September 2, 2024 13:02
@modos189
Fix eslint for core/total-conversion-build.js
679c997
@modos189
Fix eslint for core/code/app.js
ef298cd
@modos189
Fix eslint for core/code/artifact.js
ebb9e0f 
+fix `window.artifact.requestData`, replace `artifact.handleError` with `window.artifact.handleFailure`
@modos189
Fix eslint for core/code/boot.js
bff40d9
@modos189
Fix jsdoc for core/code/chat.js
add6c9c
@modos189
Fix eslint for core/code/data_cache.js
558f16d
@modos189
Fix eslint for core/code/dialog.js
fe47e7a
@modos189
Fix eslint for core/code/dialog_about.js
6ad9f48
@modos189
Fix eslint for core/code/entity_decode.js
fe0832f 
+remove `debugger` keywords from code
@modos189
Fix eslint for core/code/extract_niantic_parameters.js
ec97b2a
@modos189
Fix eslint for core/code/game_status.js
aa05973
@modos189
Fix eslint for core/code/hooks.js
a63155c
@modos189
Fix eslint for core/code/idle.js
3c8371d
@modos189
Fix eslint for core/code/layerchooser.js
341cc19
@modos189
Fix eslint for core/code/map.js
2e7a475
@modos189
Fix eslint for core/code/map_data_calc_tools.js
5ede5c9 
+remove `debugger` keywords from code
+remove erroneous tileParams value setting when returning window.getDataZoomTileParameters
@modos189
Fix eslint for core/code/map_data_debug.js
309e5e8
@modos189
Fix eslint for core/code/map_data_render.js
5076b67
@modos189
Fix eslint for core/code/map_data_request.js
ca9173e
@modos189
Fix eslint for core/code/ornaments.js
f247550 
+use logical OR instead of bitwise OR
+fix incorrect check of empty this.excludedOrnaments
@modos189
Fix eslint for core/code/panes.js
486171c
@modos189
Fix eslint for core/code/player_names.js
2c0284e
@modos189
Fix eslint for plugins/machina-tools.js
62de45d
@modos189
Fix eslint for plugins/minimap.js
67db4da
@modos189
Fix eslint for plugins/missions.js
b5d416c
@modos189
Fix eslint for plugins/multi-projects-extension.js
7bbdab6
@modos189
Fix eslint for plugins/ornament-icons.js
a19153d
@modos189
Fix eslint for plugins/ornament-icons-extended.js
0bdb21a
@modos189
Fix eslint for plugins/overlay-kml.js
52f540c
@modos189
Fix eslint for plugins/pan-control.js
156e61a
@modos189
Fix eslint for plugins/periodic-refresh.js
31a7a28
@modos189
Fix eslint for plugins/player-activity-tracker.js
4e602ea
@modos189
Fix eslint for plugins/player-level-guess.js
1d08e86
@modos189
Fix eslint for plugins/portal-counts.js
94da27a
@modos189
Fix eslint for plugins/portal-level-numbers.js
9a2f80b
@modos189
Fix eslint for plugins/portal-names.js
07ffc8c
@modos189
Fix eslint for plugins/portals-list.js
da1d4c8
@modos189
Fix eslint for plugins/regions.js
84c5cb2
@modos189
Fix eslint for plugins/remove-extra-layers.js
489c394
@modos189
Fix eslint for plugins/reso-energy-pct.js
afff48a
@modos189
Fix eslint for plugins/scale-bar.js
6f2f737
@modos189
Fix eslint for plugins/score-cycle-times.js
46dd779
@modos189
Fix eslint for plugins/scoreboard.js
4aa485a
@modos189
Fix eslint for plugins/scroll-wheel-zoom-disable.js
677df70
@modos189
Fix eslint for plugins/sync.js
d10b232
@modos189
Fix eslint for plugins/tidy-links.js
d07bb3c
@modos189
Fix eslint for plugins/uniques.js
8406c4a
@modos189
Fix eslint for plugins/zaprange.js
10f2e1a
@modos189
Fix eslint for plugins/zoom-slider.js
506ab8a
@modos189 modos189 marked this pull request as ready for review October 1, 2024 09:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk 506ab8a
test-0.38.1.20241001.095400.zip 506ab8a

See build on website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
development general development issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modos189 @xscreach @McBen