Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Android's Themed app icons #751

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Conversation

kuci-JK
Copy link
Contributor

@kuci-JK kuci-JK commented Aug 9, 2024

This PR adds support for themed app icons in launcher. (Issue #750)

Screenshot_2024-08-09-16-55-53-692_com miui home

All build variant icons here
  • Release:
    Screenshot from 2024-08-09 16-55-02
  • Beta:
    Screenshot from 2024-08-09 16-54-55
  • Debug:
    Screenshot from 2024-08-09 16-54-48
  • close #750

    Copy link

    github-actions bot commented Aug 9, 2024

    🤖 Pull request artifacts

    file commit
    IITC_Mobile-test.apk 3f6b81c
    test-0.38.1.20240819.165332.zip 3f6b81c

    See build on website

    @kuci-JK
    Copy link
    Contributor Author

    kuci-JK commented Aug 9, 2024

    The Beta icon does not currently show the text in the monochrome variant.
    I'll need to modify it slightly.
    I am leaning into cutting out the purple area in the beta label and leaving only the text.
    Something like this:
    image

    What do you guys think?

    Is there somewhere the original app icon in svg or something so it would be easy to manipulate the layers and paths?

    @modos189
    Copy link
    Contributor

    Everything we have is in the assets folder

    Is there any possibility to reduce the transparency of additional diagonal lines in the test build?

    @kuci-JK
    Copy link
    Contributor Author

    kuci-JK commented Aug 14, 2024

    Everything we have is in the assets folder

    OK, I'll try to use that for tweaking the icon for beta version.

    Is there any possibility to reduce the transparency of additional diagonal lines in the test build?

    I am not sure what do you mean can you provide a picture? I think the lines aren't transparent at all.

    @Suburbanno
    Copy link
    Contributor

    I like

    just figma.

    image

    @modos189
    Copy link
    Contributor

    I am not sure what do you mean can you provide a picture? I think the lines aren't transparent at all.

    original test builds icon

    IMAGE 2024-08-17 15:43:00

    Now the diagonal lines are hardly visible because of the similar background color. But in your example of monochrome icons for test builds these lines stand out a lot and look ugly. Is there any possibility to make these lines less noticeable, like the original icons? If there is no possibility to change their transparency, then maybe make them thinner?

    @kuci-JK
    Copy link
    Contributor Author

    kuci-JK commented Aug 19, 2024

    Ok, I have updated the icons. The current state is:

    debug:

    • I have set the alpha to 0.5 for the diagonal lines

    Screenshot from 2024-08-19 18-47-32
    Screenshot from 2024-08-19 18-47-27

    Screenshot from 2024-08-19 18-58-21

    • New on the right, Previous on the left

    beta:

    • I have cut out the part behind the square with the text so it will be readable also in the monochrome icon variant

    Screenshot from 2024-08-19 18-47-48
    Screenshot from 2024-08-19 18-47-41

    release:

    Screenshot from 2024-08-19 18-47-58
    Screenshot from 2024-08-19 18-47-54

    Let me know what you think :)

    @kuci-JK kuci-JK marked this pull request as ready for review August 19, 2024 17:03
    @kuci-JK
    Copy link
    Contributor Author

    kuci-JK commented Aug 19, 2024

    Android studio shows the thin line around the originally black pieces of the icon, but on the phone they are not visible as you can see in the screenshot here.
    image

    @Suburbanno
    Copy link
    Contributor

    Suburbanno commented Aug 19, 2024

    @kuci-JK Can't the debug icon look like this?

    image

    btw, some icon packs only did the outline

    Arcticons-Team/Arcticons
    LawnchairLauncher/lawnicons

    @modos189
    Copy link
    Contributor

    @kuci-JK Can't the debug icon look like this?

    In this case, it's hard to tell from the icon if it's a beta or a test build
    Also, I'd like to separate test builds more strongly from release and beta, as they are temporary builds intended only for testing a specific PR

    @mxxcon
    Copy link

    mxxcon commented Aug 19, 2024

    Ok, I have updated the icons.

    Let me know what you think :)

    In monochrome color theme the left and right filled in areas of the icon have a very faint light outline. Not sure if that's by design but it feels a bit like a glitch.

    @modos189 modos189 merged commit e4dd5d5 into IITC-CE:master Sep 28, 2024
    4 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    [Enhancement] Support Android's Themed app icons
    4 participants