Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloading text zoom preferences #644

Merged

Conversation

xscreach
Copy link
Contributor

@xscreach xscreach commented Jul 3, 2023

Reload the text zoom preferences without a need to restart application

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

🤖 Pull request artifacts

file commit
IITC_Mobile-test.apk 1452329
test-0.35.1.20230709.090217.zip 1452329

See build on website

@xscreach xscreach changed the title reloading webview preferences reloading text zoom preferences Jul 3, 2023
@xscreach xscreach force-pushed the feature/reloading-webview-preferences branch from 5ed7046 to 1452329 Compare July 3, 2023 13:01
@xscreach xscreach marked this pull request as ready for review July 3, 2023 13:04
Copy link
Contributor

@modos189 modos189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, the application now crashes when trying to cast a String to an Integer. My code change suggestions solve this problem

@xscreach xscreach force-pushed the feature/reloading-webview-preferences branch from b809b2d to 1452329 Compare July 9, 2023 09:01
@xscreach xscreach requested a review from modos189 July 9, 2023 09:03
@modos189 modos189 merged commit 23c077e into IITC-CE:master Jul 9, 2023
4 checks passed
@xscreach xscreach deleted the feature/reloading-webview-preferences branch July 9, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants