Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the plugin list view #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions public/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -286,5 +286,11 @@
},
"alertHostPermissionsRequiredButtonAllUrls": {
"message": "All URLs to ensure full support"
},
"pluginListEnabledPlugins": {
"message": "Enabled plugins"
},
"pluginListDisabledPlugins": {
"message": "Disabled plugins"
}
}
33 changes: 4 additions & 29 deletions src/popup/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,14 @@
<section class="section options">
<SectionOptions> </SectionOptions>
</section>
<section class="section plugins">
<SectionPlugins
v-bind:category_name="category_name"
v-bind:plugins="plugins"
v-bind:categories="categories"
>
</SectionPlugins>
</section>
<Message></Message>
<Alert></Alert>
</div>
</template>

<script>
import SectionMainMenu from "./components/SectionMainMenu.vue";
import SectionMainMenu from "./components/SectionMainMenu/SectionMainMenu.vue";
import SectionOptions from "./components/SectionOptions.vue";
import SectionPlugins from "./components/SectionPlugins.vue";

import Message from "./components/Message";
import Alert from "./components/Alert";
Expand All @@ -51,7 +42,6 @@ export default {
components: {
SectionMainMenu,
SectionOptions,
SectionPlugins,
Message,
Alert,
},
Expand Down Expand Up @@ -105,19 +95,6 @@ object {
pointer-events: none;
}

/*
* item-wrapper
*/
.item-wrapper {
border-bottom: 1px solid var(--color-white);
}
.item-wrapper:last-child {
border-bottom: 0;
}
.categories .item-wrapper:last-child {
border-bottom: 1px solid var(--color-white);
}

/*
* section
*/
Expand All @@ -138,8 +115,7 @@ body#main-menu .section.main-menu {
margin-left: 0;
z-index: 1;
}
body#options .section.options,
body#plugins .section.plugins {
body#options .section.options {
margin-left: 0;
}

Expand All @@ -156,8 +132,7 @@ body#main-menu #app.is_safari .section.main-menu {
display: block;
}

body#options #app.is_safari .section.options,
body#plugins #app.is_safari .section.plugins {
body#options #app.is_safari .section.options {
display: block;
}

Expand Down Expand Up @@ -190,7 +165,7 @@ body#plugins #app.is_safari .section.plugins {
--color-red: #ff4136;
--color-black: #111;
--color-gray: #aaa;
--color-silver: #eee;
--color-silver: #f4f4f4;
--state-on: #43a047;
--state-off: #e53935;
--state-off2: #6c3939;
Expand Down
71 changes: 0 additions & 71 deletions src/popup/components/Element.vue

This file was deleted.

144 changes: 0 additions & 144 deletions src/popup/components/SectionMainMenu.vue

This file was deleted.

33 changes: 33 additions & 0 deletions src/popup/components/SectionMainMenu/PluginList/NoData.vue
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!-- @license magnet:?xt=urn:btih:1f739d935676111cfff4b4693e3816e664797050&dn=gpl-3.0.txt GPL-v3 -->
<template>
<div class="element item-wrapper list__item">
<span class="element__text">{{ _("noData") }}</span>
</div>
</template>

<script>
import { mixin } from "@/popup/components/mixins.js";

export default {
name: "NoData",
mixins: [mixin],
};
</script>

<style scoped>
.element {
display: flex;
cursor: pointer;
padding: 4px 4px 4px 40px;
text-overflow: ellipsis;
white-space: nowrap;
background: var(--color-white);
}

.element__text {
flex: auto;
line-height: 24px;
overflow: hidden;
text-overflow: ellipsis;
}
</style>
Loading
Loading