chore(deprecations): fix some deprecations with sf 5.4 and produce va…

…r/log/test.deprecations.log to find them (refs #39)
IGNF · Nov 15, 2023 · 38cb812 · 38cb812
1 parent 128188e
commit 38cb812
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 12 deletions.
diff --git a/Makefile b/Makefile
@@ -3,7 +3,6 @@ PHP_MD_RULES=./phpmd.xml
 
 test: vendor bin/validator-cli.jar
 	APP_ENV=test XDEBUG_MODE=coverage vendor/bin/phpunit
-
 bin/validator-cli.jar:
 	bash download-validator.sh
 

diff --git a/config/packages/test/framework.yaml b/config/packages/test/framework.yaml
@@ -1,4 +1,5 @@
 framework:
   test: true
   session:
-    storage_id: session.storage.mock_file
+    storage_factory_id: session.storage.factory.mock_file
+
diff --git a/config/packages/test/monolog.yaml b/config/packages/test/monolog.yaml
@@ -2,7 +2,7 @@ monolog:
   handlers:
     main:
       type: fingers_crossed
-      action_level: error
+      action_level: info
       handler: nested
       excluded_http_codes: [404, 405]
       channels: ["!event"]

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -26,8 +26,8 @@
     <server name="SYMFONY_PHPUNIT_REMOVE" value=""/>
     <server name="SYMFONY_PHPUNIT_VERSION" value="7.5"/>
     <server name="KERNEL_CLASS" value="App\Kernel"/>
-    <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak"/>
     <!-- ###+ symfony/framework-bundle ### -->
+    <env name="SYMFONY_DEPRECATIONS_HELPER" value="logFile=var/log/test.deprecations.log"/>
     <env name="APP_ENV" value="test"/>
     <env name="APP_SECRET" value="4049513f2a2a7597f3b61c1f199a5bfa"/>
     <!-- env name="TRUSTED_PROXIES" value="127.0.0.0/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16" -->

diff --git a/src/Command/Validations/ProcessOneCommand.php b/src/Command/Validations/ProcessOneCommand.php
@@ -3,8 +3,6 @@
 namespace App\Command\Validations;
 
 use App\Validation\ValidationManager;
-use Doctrine\ORM\EntityManagerInterface;
-use Psr\Log\LoggerInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -21,16 +19,11 @@ class ProcessOneCommand extends Command
      */
     private $validationManager;
 
-
     public function __construct(
-        EntityManagerInterface $em,
-        ValidationManager $validationManager,
-        LoggerInterface $logger
+        ValidationManager $validationManager
     ) {
         parent::__construct();
-        $this->em = $em;
         $this->validationManager = $validationManager;
-        $this->logger = $logger;
     }
 
     protected function configure()