-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics #34
Add diagnostics #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this will be incorporated in a future PR that uses real/live diagnostic info. Should we move this PR back to draft?
@dangunter you are right, I just turned this PR into a draft, and start to work on serving the new UI with FastAPI and do some mockups for diagnostics. Once the API part is cleaned up and UI is approved, I can come back and update the UI template in code. if need some tests I still can use the old diagnostics UI template in this PR. For now |
The current plan is to merge #43 first and then this one (which is also expected to resolve the current CI failures). |
match request.function_name: | ||
case "display_underconstrained_set": | ||
dt.display_underconstrained_set(stream=output_stream) | ||
case "display_constraints_with_large_residuals": | ||
dt.display_constraints_with_large_residuals(stream=output_stream) | ||
case "display_potential_evaluation_errors": | ||
dt.display_potential_evaluation_errors(stream=output_stream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
match request.function_name: | |
case "display_underconstrained_set": | |
dt.display_underconstrained_set(stream=output_stream) | |
case "display_constraints_with_large_residuals": | |
dt.display_constraints_with_large_residuals(stream=output_stream) | |
case "display_potential_evaluation_errors": | |
dt.display_potential_evaluation_errors(stream=output_stream) | |
func = getattr(dt, request.function_name, None) | |
if func is None: | |
... | |
# TODO handle error | |
func(stream=output_stream) |
@CopyDemon Could you rebase this on main? I see some merge conflicts there |
Working on it now |
…ooks like Playwright was just installed or updated. Please run the following command to download new browsers:
…dFlowsheet to replace ConcreteModel
…y standard has error
…dev to find what is error in github action
…'t so copy dev to standard and test
…ist in pyproject and requirement-dev
…cs data has needed keys
Fixes
Fix the UI panel layout, remove the variables panel, and change that panel to a multi-task panel. Now it can display diagnostics.
Proposed changes:
Create a diagnostics panel to display diagnostics.
Notice
Now the diagnostics only run on fixed JSON data, later when the API is up to date, will rewrite some functions in diagnostics.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: