-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes error pointed out by Jinliang in SOC interpolation function #1314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
==========================================
- Coverage 77.41% 77.40% -0.01%
==========================================
Files 390 390
Lines 63631 63631
Branches 11702 11702
==========================================
- Hits 49258 49255 -3
- Misses 11835 11839 +4
+ Partials 2538 2537 -1 ☔ View full report in Codecov by Sentry. |
@AlexNoring @NishantGiridhar would you be able to review this soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dallan-keylogic I'll merge this after resolving the (new) failures that are happening because of #1317. |
Fixes
Switches evaluation indexes in interpolation function used in SOC submodels
Summary/Motivation:
The original interpolation function had a typo, this PR fixes it. However, I don't believe it should affect anything we've published, because the incorrect formula gives the correct answer when a uniform discretization is used.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: