Add diagnostics to Gibbs reactor tests #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
added
Priority:Normal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1305 +/- ##
==========================================
- Coverage 77.58% 77.58% -0.01%
==========================================
Files 391 391
Lines 64288 64288
Branches 11815 11815
==========================================
- Hits 49881 49878 -3
- Misses 11825 11829 +4
+ Partials 2582 2581 -1 ☔ View full report in Codecov by Sentry. |
andrewlee94
changed the title
Co-authored-by: MarcusHolly <[email protected]>
…reactor_diagnostics
andrewlee94
changed the title
bpaul4
reviewed
Feb 22, 2024
| assert pytest.approx(250.06, abs=1e-1) == value( | ||
| methane.fs.unit.outlet.flow_mol[0] | ||
| ) | ||
| assert pytest.approx(0.0, abs=1e-4) == value( | ||
| methane.fs.unit.outlet.mole_frac_comp[0, "CH4"] | ||
| ) | ||
| assert pytest.approx(0.103863, abs=1e-4) == value( |
There was a problem hiding this comment.
Why did these values change?
There was a problem hiding this comment.
I added scaling to satisfy the numerical diagnostics tests. I don;t recall the values changed that significantly.
bpaul4
approved these changes
Feb 22, 2024
agarciadiego
approved these changes
Feb 22, 2024
Co-authored-by: Brandon Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1284
Summary/Motivation:
Adds tests to assert no structural or numerical issues are present in Gibbs reactor tests.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: