Fix SOC sign error #1303
Merged
Fix SOC sign error #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
- Coverage 77.36% 77.36% -0.01%
==========================================
Files 390 390
Lines 63462 63462
Branches 11671 11671
==========================================
- Hits 49099 49096 -3
- Misses 11832 11836 +4
+ Partials 2531 2530 -1 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
pushed a commit
that referenced
this pull request
Dec 14, 2023
* fix sign error * Undo double negative, add sanity tests * run black --------- (cherry picked from commit 021fb14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a sign error in a flux calculation in the SOC channel model. Fortunately it doesn't seem to effect the current density predictions much---the integration tests still pass.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: