Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to optional dependencies installation guide #1279

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Resolves #1274

Changes proposed in this PR:

  • Add link from "Getting started" installation tutorial to optional dependencies installation guide

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:High High Priority Issue or PR label Oct 5, 2023
@lbianchi-lbl lbianchi-lbl self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb71ca3) 77.25% compared to head (17ec564) 77.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   77.25%   77.24%   -0.01%     
==========================================
  Files         387      387              
  Lines       63127    63127              
  Branches    11613    11613              
==========================================
- Hits        48768    48765       -3     
- Misses      11837    11841       +4     
+ Partials     2522     2521       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlee94 andrewlee94 enabled auto-merge (squash) October 26, 2023 18:19
@andrewlee94 andrewlee94 merged commit b278031 into IDAES:main Oct 26, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visibility for "Installing optional dependencies" documentation
3 participants