Setting pandas!=2.1.0 #1267
Merged
Setting pandas!=2.1.0 #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlee94
requested review from
lbianchi-lbl and
ksbeattie
as code owners
andrewlee94
added
bug
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
- Coverage 76.73% 76.72% -0.01%
==========================================
Files 382 382
Lines 61232 61232
Branches 11297 11297
==========================================
- Hits 46985 46982 -3
- Misses 11813 11817 +4
+ Partials 2434 2433 -1 ☔ View full report in Codecov by Sentry. |
lbianchi-lbl
approved these changes
Sep 11, 2023
OOAmusat
approved these changes
Sep 11, 2023
lbianchi-lbl
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Setting pandas!=2.1 * Specificying minor release to exclude (cherry picked from commit ab29c81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1253
Summary/Motivation:
Pandas introduced a bug in v2.1.0 that is causing Pysmo tests to fail. It looks like this bug will be fixed in the upcoming v2.1.1 pandas release.
Changes proposed in this PR:
"pandas!=2.1.0"insetup.pyto avoid using the buggy version of pandas and to allow us to switch the the corrected version once it is released.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: