Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global search and replace pyomo.core.expr.current -> pyomo.core.expr (ref pyomo PR #2910) #1234

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

strahlw
Copy link
Contributor

@strahlw strahlw commented Jul 28, 2023

Fixes

search and replace pyomo.core.expr.current -> pyomo.core.expr

Summary/Motivation:

".current" has been deprecated (see pyomo PR #2910)

Changes proposed in this PR:

  • replace deprecated imports

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@strahlw
Copy link
Contributor Author

strahlw commented Jul 28, 2023

The checks all failed because of the dependency on John's pyomo PR (#2910). On my local machine, no new issues emerged from the changes after executing the unit tests.

@andrewlee94 andrewlee94 added Priority:High High Priority Issue or PR backward-compat Affects backward compatibility pyomo labels Jul 28, 2023
@strahlw strahlw requested a review from ksbeattie as a code owner July 28, 2023 14:48
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (52d7d5c) 76.84% compared to head (0f223d4) 76.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.01%     
==========================================
  Files         390      390              
  Lines       61885    61885              
  Branches    11391    11391              
==========================================
- Hits        47555    47552       -3     
- Misses      11867    11871       +4     
+ Partials     2463     2462       -1     
Files Changed Coverage Δ
idaes/apps/uncertainty_propagation/sens.py 69.62% <100.00%> (ø)
idaes/core/util/model_statistics.py 96.70% <100.00%> (ø)
...s_extra/gas_distribution/properties/natural_gas.py 100.00% <100.00%> (ø)
...els_extra/gas_distribution/unit_models/pipeline.py 94.32% <100.00%> (ø)
..._extra/power_generation/unit_models/steamheater.py 93.07% <100.00%> (ø)
.../power_generation/unit_models/waterwall_section.py 94.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewlee94 andrewlee94 enabled auto-merge (squash) July 28, 2023 16:19
@andrewlee94 andrewlee94 merged commit 3c95188 into IDAES:main Jul 28, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compat Affects backward compatibility Priority:High High Priority Issue or PR pyomo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants