-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties and minor fixes for property sets #1230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes for pylint look good to me. However, I think we need to think a bit about whether we want to explicitly support both log10 and ln properties in order to manage the size of the list of supported properties.
Finally, there area few new properties that might be better suited to the electrolyte property set rather than the standard property set.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
- Coverage 76.84% 76.83% -0.02%
==========================================
Files 390 390
Lines 61924 61942 +18
Branches 11400 11398 -2
==========================================
+ Hits 47586 47592 +6
- Misses 11871 11882 +11
- Partials 2467 2468 +1
☔ View full report in Codecov by Sentry. |
Summary/Motivation:
Add some default properties and minor fixes for property_set
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: