Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties and minor fixes for property sets #1230

Merged
merged 27 commits into from
Aug 4, 2023
Merged

Conversation

eslickj
Copy link
Member

@eslickj eslickj commented Jul 27, 2023

Summary/Motivation:

Add some default properties and minor fixes for property_set

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@eslickj eslickj self-assigned this Jul 27, 2023
Copy link
Member

@andrewlee94 andrewlee94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixes for pylint look good to me. However, I think we need to think a bit about whether we want to explicitly support both log10 and ln properties in order to manage the size of the list of supported properties.

Finally, there area few new properties that might be better suited to the electrolyte property set rather than the standard property set.

idaes/core/base/property_set.py Outdated Show resolved Hide resolved
idaes/core/base/property_set.py Outdated Show resolved Hide resolved
idaes/core/base/property_set.py Outdated Show resolved Hide resolved
idaes/core/base/property_set.py Outdated Show resolved Hide resolved
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 27, 2023
idaes/core/base/property_set.py Outdated Show resolved Hide resolved
idaes/core/base/property_set.py Outdated Show resolved Hide resolved
pytest.ini Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 86.84% and project coverage change: -0.02% ⚠️

Comparison is base (3880c2c) 76.84% compared to head (37bc70b) 76.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.02%     
==========================================
  Files         390      390              
  Lines       61924    61942      +18     
  Branches    11400    11398       -2     
==========================================
+ Hits        47586    47592       +6     
- Misses      11871    11882      +11     
- Partials     2467     2468       +1     
Files Changed Coverage Δ
...roperties/general_helmholtz/helmholtz_functions.py 89.87% <ø> (ø)
idaes/core/base/property_meta.py 91.59% <37.50%> (-2.93%) ⬇️
idaes/core/base/property_set.py 96.55% <92.64%> (-0.59%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eslickj eslickj enabled auto-merge (squash) August 1, 2023 18:30
@eslickj eslickj merged commit deacf4c into IDAES:main Aug 4, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants