Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating RBF options in ALMAOpy #1226

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

andrewlee94
Copy link
Member

Addresses #1223

Summary/Motivation:

The current implementation of ALAMOpy does not work if radial basis function options are included. We currently do not have the resources to implement support for these, so this PR adds a check for cases where the user selects these options and raises a ConfigurationError if they are selected.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@andrewlee94 andrewlee94 self-assigned this Jul 21, 2023
@andrewlee94 andrewlee94 added bug Something isn't working Priority:Normal Normal Priority Issue or PR core Issues dealing with core modeling components surrogates backward-compat Affects backward compatibility labels Jul 21, 2023
@andrewlee94 andrewlee94 linked an issue Jul 21, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (a03ea47) 76.84% compared to head (fbc72e0) 76.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   76.84%   76.83%   -0.01%     
==========================================
  Files         390      390              
  Lines       61873    61875       +2     
  Branches    11388    11389       +1     
==========================================
- Hits        47545    47544       -1     
- Misses      11866    11870       +4     
+ Partials     2462     2461       -1     
Impacted Files Coverage Δ
idaes/core/surrogate/alamopy.py 80.82% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrewlee94 andrewlee94 enabled auto-merge (squash) July 25, 2023 16:14
@andrewlee94 andrewlee94 merged commit ad5b8ad into IDAES:main Jul 25, 2023
39 checks passed
@andrewlee94 andrewlee94 deleted the issue_1223 branch July 25, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backward-compat Affects backward compatibility bug Something isn't working core Issues dealing with core modeling components Priority:Normal Normal Priority Issue or PR surrogates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alamopy gaussian rbf basis function evaluate surrogate issue
3 participants