add water gas shift reaction

[Morgan88888888]

Fixes

Add water gas shift reaction in the natural gas properties.

Summary/Motivation:

This reaction will be used in the SMR based hydrogen generation plant in the TTNEP project.

Changes proposed in this PR:

-Add water gas shift reaction

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

[andrewlee94]

@Morgan88888888 We will need some tests and maybe some documentation for this. There also appear to be some formatting issues that need to be resolved.

[ksbeattie]

@Morgan88888888 will you be able to get this done in the next week? Otherwise it won't make the May release. And please show up to the dev call so we can talk about it.

[eslickj]

As far as I can tell there is no documentation at all for the NG property package, and no tests for the reactions at all (other than being used in testing models in other places). As best I remember, this just provides dictionaries of parameters to the generic properties and reactions package. The dictionary is configurable to select whether the EoS is ideal or cubic and what components and reactions are present. So I think the documentation can point to the generic properties and explain the options for creating the parameter dictionaries. @Morgan88888888, can you take car of this or do you need help?

We'll need to add a doc page here https://github.com/IDAES/idaes-pse/tree/main/docs/reference_guides/model_libraries/power_generation/properties, and add reaction tests to the existing test file https://github.com/IDAES/idaes-pse/blob/main/idaes/models_extra/power_generation/properties/tests/test_NG_PR.py.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (5abe575) 76.73% compared to head (3fccb94) 76.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
- Coverage   76.73%   76.72%   -0.01%     
==========================================
  Files         382      382              
  Lines       61232    61232              
  Branches    11297    11297              
==========================================
- Hits        46985    46982       -3     
- Misses      11813    11817       +4     
+ Partials     2434     2433       -1     

Files Changed	Coverage Δ
...xtra/power_generation/properties/natural_gas_PR.py	80.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

[Morgan88888888]

@Morgan88888888 will you be able to get this done in the next week? Otherwise it won't make the May release. And please show up to the dev call so we can talk about it.

I have a series of models need to be added, they are related with the hydrogen generation process in the TTNEP project. I can talk about it if there is a dev meeting on schedule tomorrow.

[Morgan88888888]

As far as I can tell there is no documentation at all for the NG property package, and no tests for the reactions at all (other than being used in testing models in other places). As best I remember, this just provides dictionaries of parameters to the generic properties and reactions package. The dictionary is configurable to select whether the EoS is ideal or cubic and what components and reactions are present. So I think the documentation can point to the generic properties and explain the options for creating the parameter dictionaries. @Morgan88888888, can you take car of this or do you need help?

We'll need to add a doc page here https://github.com/IDAES/idaes-pse/tree/main/docs/reference_guides/model_libraries/power_generation/properties, and add reaction tests to the existing test file https://github.com/IDAES/idaes-pse/blob/main/idaes/models_extra/power_generation/properties/tests/test_NG_PR.py.

Yes, I will add them. I may have some quick questions for you.

[Morgan88888888]

@Morgan88888888 We will need some tests and maybe some documentation for this. There also appear to be some formatting issues that need to be resolved.

The file is formatted. I will work with @eslickj to add test and documentation.

[ksbeattie]

@Morgan88888888 any news on this? Possible for a Nov release?

[Morgan88888888]

@Morgan88888888 any news on this? Possible for a Nov release?

Thank you for your question! It's in progress. Let's get in touch offline to discuss this further.

[ksbeattie]

@Morgan88888888, we're going to close this for now. If/When you can make progress on this, feel free to re-open it.