Updated plotting test

Updated the plot test to now plt.show() the figure. Instead, the user will use plt.show() if desired.
IDAES · Mar 4, 2024 · fb543c7 · fb543c7
1 parent d193e65
commit fb543c7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/idaes/apps/grid_integration/multiperiod/price_taker_model.py b/idaes/apps/grid_integration/multiperiod/price_taker_model.py
@@ -179,15 +179,13 @@ def get_optimal_n_clusters(
             )
 
         if plot == True:
-            plt.show()
             plt.plot(k_values, inertia_values)
             plt.axvline(x=n_clusters, color="red", linestyle="--", label="Elbow")
             plt.xlabel("Number of clusters")
             plt.ylabel("Inertia")
             plt.title("Elbow Method")
             plt.xlim(kmin, kmax)
             plt.grid()
-            plt.show()
 
         return int(n_clusters), inertia_values
 

diff --git a/idaes/apps/grid_integration/multiperiod/tests/test_price_taker.py b/idaes/apps/grid_integration/multiperiod/tests/test_price_taker.py
@@ -82,8 +82,10 @@ def test_elbow_plot(excel_data):
 
     daily_data = m.generate_daily_data(excel_data["BaseCaseTax"])
     m.get_optimal_n_clusters(daily_data, plot=True)
+    test_fig = plt.gcf()
+    plt.close('all')
 
-    assert plt.gcf() is not None
+    assert test_fig is not None
 
 
 @pytest.mark.unit