-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing duplicate files #99
base: main
Are you sure you want to change the base?
Conversation
|
@lbianchi-lbl and @ksbeattie could we remove the identified files now and deal with the bigger issue separately? |
I've updated this PR from main (which fixed a few of the things listed above) and re-ran (BTW: this skips all the @bpaul4 - The
These are small, so not that much of a problem, but @JavalVyas2000 is there a way to just have one copy of this file?
Neither of these seem to be referenced anywhere I can see in this repo. @dangunter are they still used?
@dangunter, looks like this is used in several notebooks, but only the first one? I've removed the 2nd one in this PR.
Is the
Is the
@luohezhiming, can one of these be removed?
@luohezhiming, @dangunter can 2 of these be removed?
|
@JavalVyas2000 is no longer part of the project so probably will not be able to look at those files. Are we certain those are exact duplicates of each other, or are there minor differences between the two? I suspect we probably could find a way to avoid duplication, but I wonder if it is worth the extra overhead. |
@ksbeattie the files you mentioned are essentially same but the property package they are using is with a different (each folder with a different surrogate). I am not sure of an elegant way to remove the duplication in this case. I can try to work that out but won't be able to until next week. |
Since the main drive for this PR was to address file size limitations, I'd suggest to leave those |
Yes, these are model checkpoint files that seem to be generated during model training as a place to store history data like mean squared error. I believe it's safe to remove them and ignore them in future commits - it looks like the examples still pass without them and they are regenerated when the examples run. We definitely need to keep the |
Remove duplicate files
Addresses #83 which points out that we have duplicate
logo.png
files in the repo, bloating the released package.I found a tool (
fdupes
) that will find duplicate files (via size and MD5 checksum) under a dir. So I ran it and found a few more than mention in the above PR. Specifically:Several other files were also found, like empty
__init__.py
files and notebooks, but I'd removed those from the above list, leaving ones that looked like they could be cleaned up.This is my attempt at cleaning them up, first by simply removing 2 of the
logo.png
dupes and seeing what the CI says about that.Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution:
📚 Documentation preview 📚: https://idaes-examples--99.org.readthedocs.build/en/99/