Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Fix soec notebook initialization problem #177

Closed
wants to merge 2 commits into from
Closed

Fix soec notebook initialization problem #177

wants to merge 2 commits into from

Conversation

eslickj
Copy link
Member

@eslickj eslickj commented Feb 23, 2023

Fixes issue #176

Fixes an initialization problem on the spec notebook.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@eslickj eslickj added the bug Something isn't working label Feb 23, 2023
@eslickj eslickj self-assigned this Feb 23, 2023
Copy link
Contributor

@dallan-keylogic dallan-keylogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl
Copy link
Contributor

It seems the notebook is still failing, even though one of the jobs is being reported as passing which I think is related to #116:

image

@eslickj
Copy link
Member Author

eslickj commented Feb 23, 2023

@lbianchi-lbl, checking on this error, some change in the last day or so broke this. I'm looking into it.

@eslickj
Copy link
Member Author

eslickj commented Feb 23, 2023

Okay, it was @andrewlee94's changes to model serializer that broke this one. It's my fault for using a default mutable argument, but None means something else. It will take some thinking to figure out how to properly fix this.

@eslickj
Copy link
Member Author

eslickj commented Feb 23, 2023

@lbianchi-lbl and @andrewlee94 found the problem was that the broken example was depending on changing the default arg, so the good news is that pylint is finding errors.

@eslickj
Copy link
Member Author

eslickj commented Feb 23, 2023

I'll keep working this until the tests pass.

@eslickj
Copy link
Member Author

eslickj commented Feb 24, 2023

This is too complicated to sort out. I'm just going to go ahead and move the SOFC-IES to publications. I'll close this PR and once everything is in its new home, I'll open a new PR to remove them.

@eslickj eslickj closed this Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants