Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical: remove inner datas from relative calculator #1505

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

Doresic
Copy link
Contributor

@Doresic Doresic commented Nov 12, 2024

Don't think there's any need for the inner_rdatas as well as rdatas in the output of the calculator. Looks like an artifact of something from before.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.78%. Comparing base (80a7b8d) to head (81f07a7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1505      +/-   ##
===========================================
- Coverage    82.81%   82.78%   -0.03%     
===========================================
  Files          163      163              
  Lines        13917    13916       -1     
===========================================
- Hits         11525    11520       -5     
- Misses        2392     2396       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any need for it either.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also dont see a need.

@Doresic Doresic added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit a236483 Nov 12, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants