Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: problem-specific minimize method for SaCeSS #1339

Open
wants to merge 11 commits into
base: select_use_old_calibrations
Choose a base branch
from

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Mar 26, 2024

Example use

from pypesto.optimize.ess import SacessFidesFactory
from pypesto.select import SacessMinimizeMethod

minimize_options = {
    'startpoint_method': pypesto.startpoint.UniformStartpoints(),
}
minimize_method = SacessMinimizeMethod(
    num_workers=5,
    local_optimizer=SacessFidesFactory(fides_kwargs={
        'verbose': 0,
        'hessian_update': fides.BFGS()
    }),
    max_walltime_s=60,
    sacess_loglevel=logging.DEBUG,
    ess_loglevel=logging.WARNING,
)
model_problem_options = {
    'minimize_method': minimize_method,
    'minimize_options': minimize_options,
    'objective_customizer': objective_customizer,
}

best_models = pypesto_select_problem.select_to_completion(
    candidate_space=candidate_space,
    model_problem_options=model_problem_options,
)

@dilpath dilpath requested review from dweindl and Doresic March 26, 2024 13:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (3859aef) to head (e6b5ead).

Files Patch % Lines
pypesto/select/misc.py 0.00% 27 Missing ⚠️
pypesto/select/model_problem.py 0.00% 3 Missing ⚠️
pypesto/select/__init__.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                       Coverage Diff                       @@
##           select_use_old_calibrations    #1339      +/-   ##
===============================================================
- Coverage                        80.75%   80.53%   -0.22%     
===============================================================
  Files                              161      161              
  Lines                            13465    13494      +29     
===============================================================
- Hits                             10873    10868       -5     
- Misses                            2592     2626      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks useful.

pypesto/select/misc.py Outdated Show resolved Hide resolved
pypesto/select/misc.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@dilpath
Copy link
Member Author

dilpath commented Mar 26, 2024

@Doresic you can use PEtab-dev/petab_select#86 for nicer model hashes, when saving histories

@dilpath dilpath force-pushed the select_sacess_minimize_method branch from 30a9118 to 927a28b Compare March 27, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants