add the functionality to evaluate the model using boundry values of p… #355

EmadAlamoudi · 2020-10-21T09:01:57Z

closing #353

…arameter

codecov-io · 2020-10-21T09:09:27Z

Codecov Report

Merging #355 into develop will increase coverage by 33.56%.
The diff coverage is 32.50%.

@@             Coverage Diff              @@
##           develop     #355       +/-   ##
============================================
+ Coverage    49.65%   83.21%   +33.56%     
============================================
  Files           87       88        +1     
  Lines         5017     5057       +40     
============================================
+ Hits          2491     4208     +1717     
+ Misses        2526      849     -1677

Impacted Files	Coverage Δ
pyabc/external/base.py	`71.81% <23.33%> (-18.19%)`	⬇️
pyabc/external/utils.py	`60.00% <60.00%> (ø)`
pyabc/sampler/multicore_evaluation_parallel.py	`100.00% <0.00%> (+1.63%)`	⬆️
pyabc/sampler/base.py	`94.82% <0.00%> (+1.72%)`	⬆️
pyabc/random_variables.py	`65.87% <0.00%> (+2.38%)`	⬆️
pyabc/sampler/redis_eps/cli.py	`80.71% <0.00%> (+2.85%)`	⬆️
pyabc/storage/bytes_storage.py	`100.00% <0.00%> (+3.33%)`	⬆️
pyabc/inference/smc.py	`94.84% <0.00%> (+3.86%)`	⬆️
pyabc/distance/base.py	`83.33% <0.00%> (+4.16%)`	⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10dfe65...158c8dc. Read the comment docs.

yannikschaelte · 2021-02-21T17:39:28Z

@EmadAlamoudi Should I review this?

EmadAlamoudi · 2021-02-22T15:59:23Z

It is done by me. However, I'm not sure how beneficial this to other users, what do you think?

yannikschaelte · 2021-02-22T16:03:27Z

if it helps, it never hurts to have some utility functions somewhere

yannikschaelte · 2021-05-10T15:57:04Z

@EmadAlamoudi could you resolve the merge conflicts? gonna have a look then.

yannikschaelte · 2021-11-05T13:42:42Z

@EmadAlamoudi what is the status here?

yannikschaelte

merge-in needed to resolve conflicts

codecov-commenter · 2022-06-23T08:17:26Z

Codecov Report

Merging #355 (48f3e4c) into develop (6446a77) will increase coverage by 0.25%.
Report is 227 commits behind head on develop.
The diff coverage is 89.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop     #355      +/-   ##
===========================================
+ Coverage    84.08%   84.34%   +0.25%     
===========================================
  Files           91      141      +50     
  Lines         5260     8535    +3275     
===========================================
+ Hits          4423     7199    +2776     
- Misses         837     1336     +499

Files	Coverage Δ
pyabc/__init__.py	`100.00% <100.00%> (ø)`
pyabc/acceptor/__init__.py	`100.00% <100.00%> (ø)`
pyabc/acceptor/pdf_norm.py	`96.55% <100.00%> (ø)`
pyabc/copasi/__init__.py	`100.00% <100.00%> (ø)`
pyabc/cv/__init__.py	`100.00% <100.00%> (ø)`
pyabc/cv/bootstrap.py	`100.00% <100.00%> (ø)`
pyabc/cv/powerlaw.py	`100.00% <100.00%> (ø)`
pyabc/distance/__init__.py	`100.00% <100.00%> (ø)`
pyabc/distance/kernel.py	`95.60% <100.00%> (+0.02%)`	⬆️
pyabc/epsilon/__init__.py	`100.00% <100.00%> (ø)`
... and 128 more

stephanmg · 2023-10-05T12:34:55Z

@yannikschaelte what's left here?

Use correct comparison operator.

arrjon

LGTM

* Fix assets for pyabc visserver. * Update R. * Fix for logo path in abc-server-dash * Preparing release notes for next patch release. * Updating about.rst. * Updating changelog. * Create plotly versions of selected matplotlib visualizations (#610) * Create ploty versions of selected matplotlib visualizations * update r install instructions * fix pandas float deprecation warnings * fixarray ndim > 0 float extraction deprecationwarning --------- Co-authored-by: Stephan Grein <[email protected]> * add the functionality to evaluate the model using boundry values of p… (#355) * add the functionality to evaluate the model using boundry values of parameter * fix flake8 issues * fix additional flake8 issues * add test case * flake8 fixes * flake8 fixes * flake8 fixes * flake8 fixes * flake8 fixes * black fixes * Update test_external.py Use correct comparison operator. --------- Co-authored-by: Yannik Schälte <[email protected]> Co-authored-by: Stephan Grein <[email protected]> Co-authored-by: Stephan Grein <[email protected]> --------- Co-authored-by: Yannik Schälte <[email protected]> Co-authored-by: Emad Alamoudi <[email protected]>

* Fix assets for pyabc visserver. * Update R. * Fix for logo path in abc-server-dash * Preparing release notes for next patch release. * Updating about.rst. * Updating changelog. * Create plotly versions of selected matplotlib visualizations (#610) * Create ploty versions of selected matplotlib visualizations * update r install instructions * fix pandas float deprecation warnings * fixarray ndim > 0 float extraction deprecationwarning --------- Co-authored-by: Stephan Grein <[email protected]> * add the functionality to evaluate the model using boundry values of p… (#355) * add the functionality to evaluate the model using boundry values of parameter * fix flake8 issues * fix additional flake8 issues * add test case * flake8 fixes * flake8 fixes * flake8 fixes * flake8 fixes * flake8 fixes * black fixes * Update test_external.py Use correct comparison operator. --------- Co-authored-by: Yannik Schälte <[email protected]> Co-authored-by: Stephan Grein <[email protected]> Co-authored-by: Stephan Grein <[email protected]> * Fix extra dependencies. --------- Co-authored-by: Yannik Schälte <[email protected]> Co-authored-by: Emad Alamoudi <[email protected]> Co-authored-by: Jonas Arruda <[email protected]>

add the functionality to evaluate the model using boundry values of p…

0025a51

…arameter

EmadAlamoudi and others added 3 commits October 21, 2020 11:10

fix flake8 issues

a9f00d0

fix additional flake8 issues

158c8dc

Merge branch 'develop' into eval_parameter_limits

36bb5c4

yannikschaelte assigned EmadAlamoudi Feb 22, 2021

EmadAlamoudi requested a review from yannikschaelte March 12, 2021 10:18

Merge branch 'develop' into eval_parameter_limits

a9f9ab5

yannikschaelte requested changes Nov 5, 2021

View reviewed changes

Merge branch 'develop' into eval_parameter_limits

9cc2058

EmadAlamoudi added 7 commits June 29, 2022 10:52

add test case

332d9d4

flake8 fixes

e0f3e8e

flake8 fixes

30f203a

flake8 fixes

6f4f74c

flake8 fixes

d506e52

flake8 fixes

2e467b3

black fixes

5b95ea4

EmadAlamoudi requested a review from yannikschaelte June 29, 2022 10:30

Merge branch 'develop' into eval_parameter_limits

588010d

Merge branch 'develop' into eval_parameter_limits

2b98be6

stephanmg added the enhancement label Nov 8, 2023

Update test_external.py

d5212a8

Use correct comparison operator.

stephanmg removed the request for review from yannikschaelte November 8, 2023 15:15

stephanmg requested review from stephanmg, arrjon and yannikschaelte November 8, 2023 15:15

Merge branch 'develop' into eval_parameter_limits

48f3e4c

stephanmg approved these changes Nov 10, 2023

View reviewed changes

arrjon approved these changes Nov 10, 2023

View reviewed changes

arrjon removed the request for review from yannikschaelte November 10, 2023 10:12

stephanmg merged commit d689b20 into develop Nov 10, 2023
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add the functionality to evaluate the model using boundry values of p… #355

add the functionality to evaluate the model using boundry values of p… #355

EmadAlamoudi commented Oct 21, 2020

codecov-io commented Oct 21, 2020 •

edited

Loading

yannikschaelte commented Feb 21, 2021

EmadAlamoudi commented Feb 22, 2021

yannikschaelte commented Feb 22, 2021

yannikschaelte commented May 10, 2021

yannikschaelte commented Nov 5, 2021

yannikschaelte left a comment

codecov-commenter commented Jun 23, 2022 •

edited

Loading

stephanmg commented Oct 5, 2023

arrjon left a comment

add the functionality to evaluate the model using boundry values of p… #355

add the functionality to evaluate the model using boundry values of p… #355

Conversation

EmadAlamoudi commented Oct 21, 2020

codecov-io commented Oct 21, 2020 • edited Loading

Codecov Report

yannikschaelte commented Feb 21, 2021

EmadAlamoudi commented Feb 22, 2021

yannikschaelte commented Feb 22, 2021

yannikschaelte commented May 10, 2021

yannikschaelte commented Nov 5, 2021

yannikschaelte left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 23, 2022 • edited Loading

Codecov Report

stephanmg commented Oct 5, 2023

arrjon left a comment

Choose a reason for hiding this comment

codecov-io commented Oct 21, 2020 •

edited

Loading

codecov-commenter commented Jun 23, 2022 •

edited

Loading