Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lunchpail "needs" support for installing dependencies #314

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

aavarghese
Copy link
Member

@aavarghese aavarghese commented Sep 24, 2024

Adding support for python coded worker Applications..and its dependencies to install latest python release in darwin/linux OSes.

Todo in upcoming PRs:

  1. Activate venv in boot/up rather than in preinit.sh.
  2. Get python tests to work in K8 backend.
  3. Specific version install of python and minio.
  4. Complete support for minio dependency.

lunchpail needs python 3.9 --requirements requirements.txt --venv ~/.venv

Also, future support with Files.Get (causes helm yml to json parse error):

  needs: 
     - name: python
       version: latest
       requirements: |
{{ .Files.Get "requirements.txt" | indent 8 }}

@starpit
Copy link
Member

starpit commented Sep 24, 2024

nice, what will the underlying lunchpail <> command name be?

@aavarghese
Copy link
Member Author

aavarghese commented Sep 24, 2024

nice, what will the underlying lunchpail <> command name be?

Right now, after some iterations, it is
lunchpail needs minio <version>
lunchpail needs python <version> --requirements requirements.txt --venv ~/.venv

Wdyt?

@aavarghese aavarghese closed this Sep 24, 2024
@aavarghese aavarghese reopened this Sep 24, 2024
@aavarghese aavarghese marked this pull request as ready for review October 2, 2024 21:45
@aavarghese aavarghese marked this pull request as draft October 2, 2024 21:45
@aavarghese aavarghese closed this Oct 2, 2024
@aavarghese aavarghese reopened this Oct 2, 2024
@aavarghese aavarghese changed the title feat: "dependencies" support in Application spec feat: lunchpail "needs" support in Application spec Oct 3, 2024
starpit added a commit to starpit/lunchpail that referenced this pull request Oct 3, 2024
it should hopefully be g2g now, short of missing imports (see IBM#314)

Signed-off-by: Nick Mitchell <[email protected]>
starpit added a commit that referenced this pull request Oct 3, 2024
it should hopefully be g2g now, short of missing imports (see #314)

Signed-off-by: Nick Mitchell <[email protected]>
@aavarghese aavarghese changed the title feat: lunchpail "needs" support in Application spec feat: lunchpail "needs" python support in Application spec Oct 3, 2024
starpit added a commit to starpit/lunchpail that referenced this pull request Oct 3, 2024
Will need IBM#314 to enable this test.

Signed-off-by: Nick Mitchell <[email protected]>
starpit added a commit to starpit/lunchpail that referenced this pull request Oct 3, 2024
Will need IBM#314 to enable this test.

Signed-off-by: Nick Mitchell <[email protected]>
starpit added a commit to starpit/lunchpail that referenced this pull request Oct 3, 2024
Will need IBM#314 to enable this test.

Signed-off-by: Nick Mitchell <[email protected]>
starpit added a commit that referenced this pull request Oct 3, 2024
Will need #314 to enable this test.

Signed-off-by: Nick Mitchell <[email protected]>
@aavarghese aavarghese changed the title feat: lunchpail "needs" python support in Application spec feat: lunchpail "needs" support for installing dependencies Oct 9, 2024
@aavarghese aavarghese marked this pull request as ready for review October 9, 2024 05:06
@aavarghese aavarghese merged commit 4748576 into IBM:main Oct 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants