Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional fields for Keycloak CR #2238

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

YCShen1010
Copy link
Contributor

Since the Keycloak CR issue has been verified, the cherry-pick fix is being applied to the master branch for the 4.10 release.
Issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/64888

Cherry pick PRs:
#2227
#2230

Daniel-Fan and others added 2 commits October 4, 2024 10:28
* Add optional fields for Keycloak CR

Signed-off-by: Daniel Fan <[email protected]>

* update odlm package version in go module

Signed-off-by: Daniel Fan <[email protected]>

* update keycloak resource configuration

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 8820485 into IBM:master Oct 15, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants