Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new travis job for prebuilt images #111

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add new travis job for prebuilt images #111

wants to merge 6 commits into from

Conversation

Tomcli
Copy link
Contributor

@Tomcli Tomcli commented Jul 2, 2018

This is an updated PR for #49

Note: The new Travis job only checks pre-built images working on master branch but not pending PRs because any pending PRs changes will not be reflected in the pre-built images yet. But you can find a sample prebuilt images run of this PR at https://travis-ci.org/IBM/FfDL/builds/399363365

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Makefile Outdated
@@ -32,6 +32,10 @@ PUBLIC_IP ?= 127.0.0.1
CI_MINIKUBE_VERSION ?= v0.25.1
CI_KUBECTL_VERSION ?= v1.9.4

TRAVIS_IMAGE_VERSION ?= v0.1
TEST_IMAGES = $(addprefix $(DOCKER_NAMESPACE)/, $(TEST_IMAGES_SUFFIX))
TEST_IMAGES_SUFFIX = ffdl-lcm ffdl-trainer ffdl-metrics ffdl-databroker_s3 ffdl-ui ffdl-restapi ffdl-jobmonitor ffdl-controller log_collector ffdl-databroker_objectstorage tensorboard_extract

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be pulled from a config file? Makes it easier to extend.....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can put these into a config file.

# deploy services
make $MAKE_ARGS deploy
# submit a test job
make $MAKE_ARGS test-submit-minikube-ci

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that test environment is still minikube - what all we are not able to test here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we could, but putting everything into one single job will take longer time to finish. Also, it's easier to debug the 2 different environment if we run them in parallel.

Copy link

@animeshsingh animeshsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple of comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants