-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new travis job for prebuilt images #111
base: master
Are you sure you want to change the base?
Conversation
Makefile
Outdated
@@ -32,6 +32,10 @@ PUBLIC_IP ?= 127.0.0.1 | |||
CI_MINIKUBE_VERSION ?= v0.25.1 | |||
CI_KUBECTL_VERSION ?= v1.9.4 | |||
|
|||
TRAVIS_IMAGE_VERSION ?= v0.1 | |||
TEST_IMAGES = $(addprefix $(DOCKER_NAMESPACE)/, $(TEST_IMAGES_SUFFIX)) | |||
TEST_IMAGES_SUFFIX = ffdl-lcm ffdl-trainer ffdl-metrics ffdl-databroker_s3 ffdl-ui ffdl-restapi ffdl-jobmonitor ffdl-controller log_collector ffdl-databroker_objectstorage tensorboard_extract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be pulled from a config file? Makes it easier to extend.....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can put these into a config file.
# deploy services | ||
make $MAKE_ARGS deploy | ||
# submit a test job | ||
make $MAKE_ARGS test-submit-minikube-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that test environment is still minikube - what all we are not able to test here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory we could, but putting everything into one single job will take longer time to finish. Also, it's easier to debug the 2 different environment if we run them in parallel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added couple of comments
This is an updated PR for #49
bin/travis_scripts
.Note: The new Travis job only checks pre-built images working on master branch but not pending PRs because any pending PRs changes will not be reflected in the pre-built images yet. But you can find a sample prebuilt images run of this PR at https://travis-ci.org/IBM/FfDL/builds/399363365
Developer's Certificate of Origin 1.1