Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow countries attribute as string #412

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Allow countries attribute as string #412

merged 3 commits into from
Oct 10, 2024

Conversation

dc-almeida
Copy link
Collaborator

Closes #398

@dc-almeida dc-almeida self-assigned this Oct 10, 2024
danielhuppmann
danielhuppmann reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more user-friendly to always have the countries as a list internally - otherwise, users wanting to work with that attribute have to check whether it's a list every time in their scripts...

See the implementation as suggestions inline.

tests/data/codelist/region_codelist/countries_attribute_str/region.yaml Outdated Show resolved Hide resolved
nomenclature/code.py Outdated Show resolved Hide resolved
nomenclature/code.py Outdated Show resolved Hide resolved
danielhuppmann
danielhuppmann approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@dc-almeida dc-almeida merged commit 8850c9d into IAMconsortium:main Oct 10, 2024
11 checks passed
@dc-almeida dc-almeida deleted the allow-countries-str branch October 10, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

Assignees

@dc-almeida dc-almeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

countries attribute doesn't allow for single country string input
2 participants
@dc-almeida @danielhuppmann