Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back Windows tests #375

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Bring back Windows tests #375

merged 4 commits into from
Sep 16, 2024

Conversation

phackstock
Copy link
Contributor

Closes #372, closes #364.

@phackstock phackstock added the bug Something isn't working label Sep 3, 2024
@phackstock phackstock self-assigned this Sep 3, 2024
@phackstock
Copy link
Contributor Author

Removing the cached environment fixes the tests since the failing step is skipped.

danielhuppmann
danielhuppmann approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phackstock
Copy link
Contributor Author

@danielhuppmann, sorry for the confusion, I'm not sure that this one is actually fixed.
I think the tests fail if the step "Install library" actually needs to be run because the loaded cached environment is not sufficient.
This is from the latest run that succeeded:
image
I think it succeeded because I manually deleted the environment which forced a cache refresh which means that "Install library" could be skipped.
I'm not fully sure what's going on so I'd keep this PR open for now.
Seems that we need to change a few things for making running on Windows smooth https://github.com/snok/install-poetry#running-on-windows (this is the GH action we use to set up poetry).

@phackstock phackstock merged commit 367e10c into IAMconsortium:main Sep 16, 2024
21 checks passed
@phackstock phackstock deleted the fix/windows-tests-on-GitHub branch September 16, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

Assignees

@phackstock phackstock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows tests currently (Aug 29 2024) broken Windows tests failing due to matplotlib error
2 participants
@phackstock @danielhuppmann