Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid): Fix regression in global gridding #51

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(grid): Fix regression in global gridding #51

merged 1 commit into from
May 21, 2024

Conversation

coroa
Copy link
Collaborator

@coroa coroa commented May 16, 2024 •
edited
Loading

as_flux is replaced by whether a cell_area is provided.
instead of on demand cell_area is now always built by the from_variables constructor.

@coroa
fix(grid): Fix regression in global gridding
561a36a 
as_flux is replaced by whether a cell_area
is provided. instead of on demand
cell_area is now always constructed by the
`from_variables` constructor.
@coroa coroa requested a review from gidden May 16, 2024 06:13
@coroa
Copy link
Collaborator Author

coroa commented May 16, 2024

Fixes point 10 of #45 :

  1. changing to "variabledefs-region" however leads to KeyError: 'global' in when running workflow.harmonize_and_downscale()

gidden
gidden reviewed May 20, 2024
View reviewed changes
Copy link
Member

@gidden gidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean a user has to provide their own cell area if they don't use this constructor? Do we want to make it slightly more convenient in some way?

@coroa
Copy link
Collaborator Author

coroa commented May 21, 2024

Proxy should always be built by a constructor. This one is now rescue specific, but for moving the grid.py module into aneris we mainly need a generalized constructor, generating the cell_area moves then there.

@gidden gidden merged commit ed78b22 into main May 21, 2024
@coroa coroa deleted the fix-regression-global-gridding branch May 21, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gidden gidden gidden left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coroa @gidden