Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getSysUserId into a Separate Class #1272

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Ariho-Seth
Copy link

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a screenshot showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

A new package i.e org.openelisglobal.common.userId was created and a new class that contains the only one method i.e protected String getSysUserId was created
This class acts as a super class to all the classes that were inheriting the BaseRestController class and it also implements the IActionConstants interface

Screenshots

screen

IssueNumber
#1222
Go to Issue
#1222

Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ariho-Seth for attempting to work on this.
I dont think the issue required renaming BaseRestController to SysUserId .
it only required removing getSysUserId from any controller and use the reusable method from the baseClass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants