Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing rewriting test notification config menu page #1204

Merged
merged 13 commits into from
Sep 19, 2024
Merged

Fixing rewriting test notification config menu page #1204

merged 13 commits into from
Sep 19, 2024

Conversation

adityadeshlahre
Copy link
Contributor

WIP

WORKFLOW video soon

If any changes are required let me know 🙂
Thank You

@adityadeshlahre
Copy link
Contributor Author

WORKFLOW (testNotificationConfigMenu/Edit) pages

testNOTIFICATIONWorkFLOW

🙂

@mozzy11 mozzy11 marked this pull request as ready for review August 1, 2024 18:21
@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Aug 12, 2024
@adityadeshlahre adityadeshlahre force-pushed the fix-rewriting-TestNotificationConfigMenu-page branch from 11008d1 to c3f5940 Compare August 21, 2024 15:31
@github-actions github-actions bot removed the merge conflict Merge Conflicts label Aug 22, 2024
@mozzy11
Copy link
Collaborator

mozzy11 commented Aug 22, 2024

@adityadeshlahre is this ready for review ??
can you add a screen recording ??

mozzy11
mozzy11 requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@mozzy11 mozzy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityadeshlahre can you add a screen recording ??

@github-actions GitHub Actions
Copy link

👋 Hi, @adityadeshlahre,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label Aug 22, 2024
@adityadeshlahre adityadeshlahre force-pushed the fix-rewriting-TestNotificationConfigMenu-page branch from 9f907bc to 2a5b3ab Compare August 22, 2024 15:04
@adityadeshlahre
Copy link
Contributor Author

@adityadeshlahre can you add a screen recording ??

#1204 (comment)

In this comment there is workflow video already present its taking sometime to load !

@github-actions github-actions bot removed the merge conflict Merge Conflicts label Aug 22, 2024
@mozzy11 mozzy11 merged commit 4bc1b3d into I-TECH-UW:develop Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozzy11 mozzy11 mozzy11 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adityadeshlahre @mozzy11