Fix runParserFully, add Flag' #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to use optparse-idris for a project but I found a couple things worth fixing.
runParserFullywas only specified for an argument list ofNil. The existing implementation seemed to be already handling theConscase well so I've just replace the pattern match by a variable.I also needed a
flag' : a -> (Option FlagParams a -> Option FlagParams a) -> Parser aconstruct in order to toggle an optional argument. Tell me is this is a welcome addition.Finally I've used the shortcut syntax of do-notation instead of relying on
case oftell me if this is a welcome addition as well.ps: I've tried using
helpbut it seems like it's type signature doesn't return the same lens asshortandlongany pointers to help me generate the help field?