-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OPTIC-1095: Send the started_at time of when annotation work had began #6408
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
@ellipsis-dev review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 15285f7 in 20 seconds
More details
- Looked at
34
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. web/libs/datamanager/src/sdk/lsf-sdk.js:930
- Draft comment:
The calculation ofadjustedStartedAt
seems incorrect. It should subtractdraftLeadTime
fromdraftStartedAt
instead of adding it. This will correctly adjust for the time the user was not actively labeling. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The logic in the code seems to be thatdraftLeadTime
is the time spent on the draft, and adding it todraftStartedAt
gives the total time including the draft. The comment suggests subtracting, which would imply reducing the start time by the draft time, which doesn't make sense in this context. The comment seems incorrect.
I might be misunderstanding the purpose ofdraftLeadTime
. If it represents time not spent on the draft, then subtraction would make sense. However, the code comments suggest it is time spent, supporting addition.
The code comments explicitly state thatdraftLeadTime
is subtracted from the current time to adjust the start time, which aligns with the code's logic of adding it todraftStartedAt
. This supports the idea that the comment is incorrect.
The comment is incorrect because the logic of addingdraftLeadTime
todraftStartedAt
aligns with the code's purpose of adjusting for time spent on the draft. The comment should be deleted.
Workflow ID: wflow_WFnPElUT4eFmTclx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
⌛ 2 days left in your free trial, upgrade for $20/seat/month or contact us.
…ead time, with a min value being the draftStartedAt time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need a clarification of expectation - otherwise approved
Co-authored-by: yyassi-heartex <[email protected]>
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
Based on @wesleylima's investigation work into better reporting of lead_time's, we have to be sending when work actually started with regards to a given task, so that every history item reflects the period in which work was performed.
Does this PR introduce a breaking change?
(check only one)
Which logical domain(s) does this change affect?
Annotation History, Annotation Draft, Annotation.
feat: add started_at timestamp for annotation start tracking in LSFWrapper
Summary:
Adds
started_at
timestamp to track when annotation work began inLSFWrapper
inlsf-sdk.js
.Key points:
started_at
timestamp to annotation results inLSFWrapper
inlsf-sdk.js
.started_at
as the earliest of draft creation orloadedDate
, adjusted for draft lead time.started_at
does not exceed current time, defaults toloadedDate
if so.prepareData()
function to includestarted_at
in the result object.Generated with ❤️ by ellipsis.dev