fix: OPTIC-1107: [timebox] visual inconsistency with datamanager on smaller screens #6379
Conversation
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yyassi-heartex
changed the title
|
@ellipsis-dev review this |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6379 +/- ##
========================================
Coverage 76.57% 76.58%
========================================
Files 169 169
Lines 13753 13753
========================================
+ Hits 10532 10533 +1
+ Misses 3221 3220 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d0dda2d in 20 seconds
More details
- Looked at
30lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_iTQjHT79bXi9pJDk
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
| } | ||
|
|
||
| :global(.app-wrapper) { | ||
| flex: 1; | ||
| } | ||
|
|
||
| .app-wrapper { |
There was a problem hiding this comment.
not sure this is actually applying to anything - anyone against removing this block?
| @@ -9,6 +9,11 @@ body { | |||
|
|
|||
| margin: 0; | |||
| font-family: Figtree, sans-serif; | |||
| display: flex; | |||
There was a problem hiding this comment.
This possibly breaks the other pages, as flex would not be the default layout for body.
|
/git merge develop
|
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
addressing a visual issue that occurs when the screen is sufficiently small enough where control bar extends past the edge of all other elements leading to a weird visual
fix: OPTIC-1107: Adjust app layout for small screens
Summary:
Fixes layout issue on small screens by adjusting flexbox properties in
login.cssandApp.scss.Key points:
login.css, addedflex: 1;tohtml, bodyfor full height usage.App.scss, addeddisplay: flex;tobodyandflex: 1;to:global(.app-wrapper)for consistent layout.Generated with ❤️ by ellipsis.dev