hdf5: backport c++ regression fix #192880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Oct 5, 2024
github-actions
bot
added
the
autosquash
github-actions
bot
removed
the
autosquash
SMillerDev
reviewed
Oct 5, 2024
github-actions
bot
added
the
autosquash
SMillerDev
approved these changes
Oct 5, 2024
backports HDFGroup/hdf5#4473 to fix a regression in the c++ layer (H5Group::operator= not handling exceptions) else the c++ layer crashes in the new 1.14.4.3 version just published on homebrew
github-actions
bot
removed
the
autosquash
iMichka
added
CI-skip-recursive-dependents
chenrui333
approved these changes
Oct 6, 2024
|
Thanks @jschueller! |
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports HDFGroup/hdf5#4473 to fix a regression in the c++ layer (H5Group::operator= not handling exceptions)
Else the c++ layer crashes in the new 1.14.4.3 version just published on homebrew
/cc @chenrui333 @samford since you recently updated this formula
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?