Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6: turn off CGO #165140

Closed
wants to merge 1 commit into from
Closed

k6: turn off CGO #165140

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

turn off CGO, it has some glibc linker issue on linux, upstream has made the similar change on 0.26.0 release.

see https://github.com/grafana/k6/blob/master/release%20notes/v0.26.0.md?plain=1#L127

relates to #163826

turn off CGO, it has some glibc linker issue on linux, upstream has made the similar change on 0.26.0 release.

see https://github.com/grafana/k6/blob/master/release%20notes/v0.26.0.md?plain=1#L127

Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Mar 5, 2024
@chenrui333 chenrui333 marked this pull request as draft March 5, 2024 19:56
@chenrui333
Copy link
Member Author

put the PR into draft mode before we decide the direction

@chenrui333 chenrui333 closed this Mar 6, 2024
@chenrui333
Copy link
Member Author

close for now, once the root cause is more clear with the old linux, will reopen for discussion later.

@chenrui333 chenrui333 deleted the k6-cgo branch March 6, 2024 00:40
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue go-cgo outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant