Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add reporting to the scheduled check #158644

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hopefully, this will give us advanced warning of build issues.

@SMillerDev SMillerDev requested review from MikeMcQuaid and a team as code owners December 31, 2023 10:33
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Dec 31, 2023
@SMillerDev
Copy link
Member Author

@Homebrew/core how do people feel about posting failures that occur here to an issue that we mark as "good first issue"? It'll allow people to pick up some small maintenance tasks inbetween big updates.

@MikeMcQuaid
Copy link
Member

@Homebrew/core how do people feel about posting failures that occur here to an issue that we mark as "good first issue"? It'll allow people to pick up some small maintenance tasks inbetween big updates.

@SMillerDev Seems reasonable to me if they are sufficiently obvious what the errors are.

@SMillerDev SMillerDev force-pushed the SMillerDev-patch-1 branch 2 times, most recently from 4e457f8 to 6dca691 Compare January 1, 2024 13:21
@SMillerDev
Copy link
Member Author

See #139929, I think I'll turn off the build reporting for now, until I find a good way to skip it when the problem is that it's not supported on that platform.

CI: add reporting to issue
@SMillerDev SMillerDev changed the title CI: add a build to the scheduled check CI: add reporting to the scheduled check Jan 3, 2024
@SMillerDev SMillerDev added this pull request to the merge queue Jan 4, 2024
Merged via the queue into master with commit 32966c8 Jan 4, 2024
62 of 63 checks passed
@SMillerDev SMillerDev deleted the SMillerDev-patch-1 branch January 4, 2024 18:19
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants