Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offlineimap: use python-certifi formula #138643

Merged
merged 2 commits into from
Aug 5, 2023
Merged

offlineimap: use python-certifi formula #138643

merged 2 commits into from
Aug 5, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Aug 5, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 5, 2023
iMichka
iMichka requested changes Aug 5, 2023
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, your gpg check is "unverified", is that ok?

@alex
Copy link
Contributor Author

alex commented Aug 5, 2023

It's signed with https://github.com/sigstore/gitsign

@iMichka
Copy link
Member

iMichka commented Aug 5, 2023

image

It's just that is shows up as unverified in GitHub.

@alex
Copy link
Contributor Author

alex commented Aug 5, 2023

See sigstore/gitsign#40

iMichka
iMichka approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@iMichka iMichka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) This makes sense now.

@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label Aug 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 5, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 5, 2023
Merged via the queue into Homebrew:master with commit e6ab62e Aug 5, 2023
12 checks passed
@alex alex deleted the offlineimap-certifi branch August 5, 2023 23:27
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka approved these changes

@github-actions GitHub Actions GitHub Actions approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alex @iMichka @BrewTestBot @p-linnane