xrootd: update to 5.6.1 #136074
Closed
xrootd: update to 5.6.1 #136074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
reviewed
Jul 7, 2023
carlocab
requested changes
Jul 7, 2023
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jul 7, 2023
Needed for Homebrew#136074.
|
Maybe bump this to 5.6.1? |
|
@pthariensflame might be blocked here. Feel free to open a new PR for 5.6.1. |
Closed
|
Yes, please bump to 5.6.1, I've made a fix to find the kernel uuid so the ossp-uuid dependency can be dropped. |
Option ENABLE_CRYPTO has been removed in 5.6, it is now always enabled/required. CMake build system moved to use the new module FindPython.cmake, so need to replace PYTHON_EXECUTABLE with Python_EXECUTABLE.
|
Please note the changes in build options. Please prefer this to #136388, as python may be configured incorrectly without the change from this pull request. Cheers, |
amadio
changed the title
|
The failure is during configuration, it doesn't look like this is a problem with the formula itself. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
I will release 5.6.2 soon, so let's close this one and I will open a new one once the new version is out. Cheers, |
chenrui333
added
superseded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option ENABLE_CRYPTO has been removed in 5.6, it is now always enabled/required. CMake build system moved to use the new module FindPython.cmake, so need to replace PYTHON_EXECUTABLE with Python_EXECUTABLE.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?