Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete roblox.rb #81347

Merged
merged 1 commit into from
May 22, 2020
Merged

Delete roblox.rb #81347

merged 1 commit into from
May 22, 2020

Conversation

core-code
Copy link
Contributor

the cask does not work as-is. someone would need to spend the time to change this to an installer stanza so we can keep it: #71440 (comment)

the cask does not work as-is. someone would need to spend the time to change this to an installer stanza so we can keep it: #71440 (comment)
@ran-dall
Copy link
Contributor

@core-code If I have a second tomorrow for personal entertainment; I'll fix it and let you know...otherwise, feel free to merge.

@core-code
Copy link
Contributor Author

thanks there, looking forward to a fix :) i wont merge my own delete requests anyway so it would be up to other maintainers there...

@ran-dall
Copy link
Contributor

ran-dall commented Apr 26, 2020

thanks there, looking forward to a fix :) i wont merge my own delete requests anyway so it would be up to other maintainers there...

@core-code Cool, I'll merge this I can't fix it.

@vitorgalvao
Copy link
Member

The assignment is for organisational purposes only. You’re still free to fix or merge, however you see fit.

@ran-dall
Copy link
Contributor

ran-dall commented May 3, 2020

Still working on it...

@ran-dall
Copy link
Contributor

Frankly, unless we get really creative with this, I don't think there's a way of making it work, so I'm going to go ahead and merge this...

@ran-dall ran-dall merged commit a77025b into master May 22, 2020
@ran-dall ran-dall deleted the core-code-patch-1 branch May 22, 2020 15:51
@foxt
Copy link

foxt commented Jun 23, 2020

In which way? The site downloads a DMG with a executable in it, are GUIs opening a no-go for casks? (I'd see why)

@ran-dall
Copy link
Contributor

ran-dall commented Jun 23, 2020

@theLMGN Well if my memory serves correctly, the installation process didn't have a way of really working together with the HBC. Some GUI-based installers do.

@core-code
Copy link
Contributor Author

In which way? The site downloads a DMG with a executable in it, are GUIs opening a no-go for casks? (I'd see why)

its not an 'executable' in the sense of a runnable app, but it is an installer. we'd need an 'installer manual' stanza to make it work. PRs are welcome.

@ran-dall
Copy link
Contributor

FWIW installer manual is the only solution to this, which isn't very elegant IMO.

@vitorgalvao
Copy link
Member

are GUIs opening a no-go for casks?

Correct. As @core-code and @ran-dall mentioned, it would need to be an installer manual:. But we’d like to change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants