semeru-jdk-open 23+37 #185890
Open
semeru-jdk-open 23+37 #185890
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBrousseau
force-pushed
the
semeru23
branch
5 times, most recently
from
3d5e486
to
a039ab5
Compare
|
I believe I've fixes all the errors I can. Let me know if there's anything else or if I need to squash my commits. |
SMillerDev
reviewed
Sep 19, 2024
Casks/s/[email protected]
Outdated
| @@ -0,0 +1,27 @@ | |||
| cask "semeru-jdk-open@22" do | |||
There was a problem hiding this comment.
Will this still be supported upstream?
There was a problem hiding this comment.
Good point, 22.0.2.1 (22.0.2+9) is the last release. Shall I remove this then? Technically it is still a "secure" level until the Oct CPU releases.
There was a problem hiding this comment.
Yeah, I would say we can just drop it.
There was a problem hiding this comment.
Ok. Should I backport the changes into any of the previous versions or just leave them in the latest rb?
Switch to 3 version fields to support initial GA releases. Signed-off-by: Adam Brousseau <[email protected]>
AdamBrousseau
force-pushed
the
semeru23
branch
from
a039ab5
to
5f0ebe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move 22 to a new rb file
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.