Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium: add livecheck #174163

Merged
merged 1 commit into from
May 17, 2024
Merged

vscodium: add livecheck #174163

merged 1 commit into from
May 17, 2024

Conversation

samford
Copy link
Member

@samford samford commented May 17, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

By default, livecheck checks the Git tags for vscodium and it correctly returns 1.89.1.24130 as the latest version but the releases after 1.88.1.24104 haven't provided assets for macOS because of a temporary technical issue (see VSCodium/vscodium#1868).

This adds a GithubReleases livecheck block to restrict matching to releases with dmg files. We should be able to switch to strategy :github_latest once upstream provides dmg files in subsequent releases but this addresses the issue for the moment.

@samford samford added the livecheck Issues or PRs related to livecheck label May 17, 2024
By default, livecheck checks the Git tags for `vscodium` and it
correctly returns 1.89.1.24130 as the latest version but the releases
after 1.88.1.24104 haven't provided assets for macOS because of a
temporary technical issue.

This adds a `GithubReleases` `livecheck` block to restrict matching
to releases with dmg files. We should be able to switch to
`strategy :github_latest` once upstream provides dmg files in
subsequent releases but this addresses the issue for the moment.
@krehel krehel merged commit 7ed1520 into master May 17, 2024
9 checks passed
@krehel krehel deleted the vscodium-add-livecheck branch May 17, 2024 17:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
livecheck Issues or PRs related to livecheck outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants