vscodium: add livecheck #174163
Merged
vscodium: add livecheck #174163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, livecheck checks the Git tags for `vscodium` and it correctly returns 1.89.1.24130 as the latest version but the releases after 1.88.1.24104 haven't provided assets for macOS because of a temporary technical issue. This adds a `GithubReleases` `livecheck` block to restrict matching to releases with dmg files. We should be able to switch to `strategy :github_latest` once upstream provides dmg files in subsequent releases but this addresses the issue for the moment.
samford
force-pushed
the
vscodium-add-livecheck
branch
from
34e9cf5
to
155f056
Compare
krehel
approved these changes
May 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.By default, livecheck checks the Git tags for
vscodiumand it correctly returns 1.89.1.24130 as the latest version but the releases after 1.88.1.24104 haven't provided assets for macOS because of a temporary technical issue (see VSCodium/vscodium#1868).This adds a
GithubReleaseslivecheckblock to restrict matching to releases with dmg files. We should be able to switch tostrategy :github_latestonce upstream provides dmg files in subsequent releases but this addresses the issue for the moment.