clean up fetch_bottle_tab

Homebrew · Sep 10, 2024 · 44970f7 · 44970f7
1 parent 17b6948
commit 44970f7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb
@@ -1282,16 +1282,18 @@ def previously_fetched_formula
 
   sig { void }
   def fetch_bottle_tab
-    @fetch_bottle_tab ||= begin
+    return if @fetch_bottle_tab
+
+    begin
       formula.fetch_bottle_tab
       @bottle_tab_runtime_dependencies = formula.bottle_tab_attributes
                                                 .fetch("runtime_dependencies", []).then { |deps| deps || [] }
                                                 .each_with_object({}) { |dep, h| h[dep["full_name"]] = dep }
                                                 .freeze
-      true
     rescue DownloadError, ArgumentError
-      @fetch_bottle_tab = T.let(true, T.nilable(TrueClass))
+      # do nothing
     end
+    @fetch_bottle_tab = T.let(true, T.nilable(TrueClass))
   end
 
   sig { void }