Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to continue setup procedure even if Wifi is Disconnect. #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

computergeek1507
Copy link

Do not know if this is the best way to do this, but I hope it gives you an idea what I want

@Hieromon Hieromon mentioned this pull request Jun 16, 2019
@mdeanda
Copy link

mdeanda commented Sep 16, 2020

This missing feature is kind of putting me on the fence between using autoconnect or just hard-coding the wifi info and using a less future-proof solution like autoconnect... however it doesn't seem like this method would allow it to eventually connect in the future when wifi comes back online but I haven't looked at the autoconnect code myself so perhaps it does.

@Hieromon
Copy link
Owner

@computergeek1507 Thank you for PR.
We can assume various situations as the WiFi disconnection state of ESP8266, but it is not clear which one this PR assumes. It probably aims to prevent the ESP module from falling into a standalone state at the beginning of the sketch, but on the other hand, it is possible with the proper combination of autoRise and portalTimeout in AutoConnectConfig.
What are the specific effects of your point of view?

@computergeek1507
Copy link
Author

I am using a esp32 board with a Ethernet adapter. I want the user to connect to the esp32 wifi AP and be able to configure the Ethernet settings thought a custom page and then disconnect from wifi and let the program run using the Ethernet connection. By added this parameter it allowed the setup method to "finish" and let the main loop code run using the Ethernet connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants